-
Notifications
You must be signed in to change notification settings - Fork 505
Add additional optimizations to SimplifySelectCases midend pass#5372
Draft
kfcripps wants to merge 2 commits intop4lang:mainfrom
Draft
Add additional optimizations to SimplifySelectCases midend pass#5372kfcripps wants to merge 2 commits intop4lang:mainfrom
SimplifySelectCases midend pass#5372kfcripps wants to merge 2 commits intop4lang:mainfrom
Conversation
Contributor
Reduces the following parser code:
state state_1 {
transition select(packet.lookahead>()) {
0x21 : state_3;
0x21 : state_2;
default : accept;
}
}
to:
state state_1 {
transition select(packet.lookahead>()) {
0x21 : state_3;
default : accept;
}
}
and reduces the following parser code:
state state_1 {
transition select(packet.lookahead>()) {
0x21 : state_3;
0x22 : state_2;
default : state_3;
}
}
to:
state state_1 {
transition select(packet.lookahead>()) {
0x22 : state_2;
default : state_3;
}
}
kfcripps
force-pushed
the
simplify-select-cases
branch
from
September 17, 2025 23:39
465a4ce to
6aaa0e4
Compare
Signed-off-by: kfcripps
Signed-off-by: Kyle Cripps
kfcripps
force-pushed
the
simplify-select-cases
branch
from
November 19, 2025 01:03
6aaa0e4 to
902b6c2
Compare
ChrisDodd
approved these changes
Nov 19, 2025
|
|
||
| bool isCompileTimeConstant(const IR::Expression *expr, const TypeMap *typeMap) { | ||
|
if (expr->is |
||
|
if (expr->is |
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems to be checking for an actual constant, not a compile-time constant (compile-time constants also include directionless parameters that will be bound to a constant in an instantiation), so seems misnamed. perhaps just isConstant?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.