Light Mode

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Comments

Debug VITS for multi-speaker training#6

Merged
RMSnow merged 3 commits intoopen-mmlab:mainfrom
lmxue:vits_ms_debug
Dec 4, 2023
Merged

Debug VITS for multi-speaker training#6
RMSnow merged 3 commits intoopen-mmlab:mainfrom
lmxue:vits_ms_debug

Conversation

Copy link
Collaborator

lmxue commented Dec 3, 2023

  • Update code for multi-speaker VITS training
  • Update some other files

lmxue requested review from HeCheng0625, RMSnow, VocodexElysium and zhizhengwu December 3, 2023 11:46
zhizhengwu reviewed Dec 3, 2023
"trian_stage": self.args.train_stage
}
return state_dict
# def _get_state_dict(self):
Copy link
Collaborator

zhizhengwu Dec 3, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this impacted?

Copy link
Collaborator

RMSnow Dec 3, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the commented code implemented in any base trainer (new_trainer or tts_trainer)? If so, we can just delete them.

Copy link
Collaborator Author

lmxue Dec 3, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's the testing code before. And unuseful now. I have deleted it.

RMSnow requested changes Dec 3, 2023
"trian_stage": self.args.train_stage
}
return state_dict
# def _get_state_dict(self):
Copy link
Collaborator

RMSnow Dec 3, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the commented code implemented in any base trainer (new_trainer or tts_trainer)? If so, we can just delete them.

RMSnow approved these changes Dec 4, 2023
RMSnow merged commit 656a5bd into open-mmlab:main Dec 4, 2023
KhryptorGraphics pushed a commit to KhryptorGraphics/Amphion that referenced this pull request Feb 2, 2026
debug vits with multi-speaker training, and upate some other files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

zhizhengwu zhizhengwu left review comments

RMSnow RMSnow approved these changes

HeCheng0625 Awaiting requested review from HeCheng0625

VocodexElysium Awaiting requested review from VocodexElysium

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants