-
-
Notifications
You must be signed in to change notification settings - Fork 302
Conversation
Owner
Fix web server shutting down when YouTube API errors occur during feed updates.
Use a separate context for feed updates so they aren't cancelled by web server lifecycle events, and treat http.ErrServerClosed as a non-error to prevent unnecessary errgroup context cancellation.
Fixes #837
Use a separate context for feed updates so they aren't cancelled by
web server lifecycle events. Treat http.ErrServerClosed as a non-error
to prevent unnecessary errgroup context cancellation.
Co-authored-by: Maksym Pavlenko
web server lifecycle events. Treat http.ErrServerClosed as a non-error
to prevent unnecessary errgroup context cancellation.
Co-authored-by: Maksym Pavlenko
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.