-
-
Notifications
You must be signed in to change notification settings - Fork 300
Fix: display episode images from RSS item tags in HTML UI#825
Open
elalemanyo wants to merge 1 commit intomxpv:mainfrom
Open
Fix: display episode images from RSS item tags in HTML UI#825elalemanyo wants to merge 1 commit intomxpv:mainfrom
elalemanyo wants to merge 1 commit intomxpv:mainfrom
Conversation
Contributor
Fixes a bug where episode images were not shown in the web UI.
The parser now checks common item-level image locations (namespaced itunes:image, media:thumbnail / media:content, and plain image), and falls back to channel-level images when necessary.
Changes:
- Use
querySelectorwith namespace escapes foritunes:image. - Add checks for
media:thumbnail/media:contentand plain image elements. - Add basic favicon
- Remove some spaces
Owner
|
@chkuendig PTAL |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.