-
Notifications
You must be signed in to change notification settings - Fork 5
Conversation
Codecov Report Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #331 +/- ## ========================================== + Coverage 84.31% 84.60% +0.28% ========================================== Files 16 16 Lines 1556 1585 +29 ========================================== + Hits 1312 1341 +29 Misses 141 141 Partials 103 103
Flags with carried forward coverage won't be shown. Click here to find out more. View full report in Codecov by Sentry. New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Adds execution-time support for MySQL/SingleStore DELIMITER directives and introduces an opt-in migration option to preserve SQL comments so comment-only statements can be executed (primarily for test coverage).
Changes:
- Add
libschema.PreserveComments()migration option and plumb it into SQL execution. - Update Postgres tests to preserve comments for comment-only migrations.
- Add MySQL and SingleStore integration tests covering delimiter-based stored procedure migrations.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
api.go |
Adds preserveComments flag + PreserveComments() option/accessor on migrations. |
internal/mhelp/run_sql.go |
Executes statements from token lists; now conditionally strips comments and strips leading/trailing delimiter directives. |
lspostgres/non_tx_test.go |
Updates comment-only migration test to use PreserveComments(). |
lspostgres/bad_test.go |
Updates RepeatUntilNoOp/comment-only migration case to use PreserveComments(). |
lsmysql/mysql_test.go |
Adds delimiter migration test + shared helper for delimiter-based migrations. |
lsmysql/singlestore_test.go |
Adds SingleStore wrapper test to reuse the MySQL delimiter helper. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.