-
Notifications
You must be signed in to change notification settings - Fork 709
Updating ssh protocol to support disconnect message and language in packet#1455
Updating ssh protocol to support disconnect message and language in packet#1455Luwdo wants to merge 2 commits intomscdex:masterfrom
Conversation
This allows more fine grained control of the disconnect message packet. Allowing custom authentication implementations to communicate to clients the reason for connection failure.
A common pattern that openssh implements is an authentication failure limit. Resulting in the following message:
Received disconnect from 10.99.33.252 port 30372:2: Too many authentication failures
Disconnected from 10.99.33.252 port 30372
ssh2 js can implement this but there was no way to pass back a human readable message or change the reason to PROTOCOL_ERROR: 2 which is most appropriate for a "Too many authentication failures" message.
Fall back is set to reason: BY_APPLICATION so those who do not implement custom authentication exit patterns won't be affected.
|
This is still an issue that is hiding ssh client visibility of messages concerning the reason why a connection was rejected. |
|
This needs a test. |
I can work on getting a test added to my PR. |