-
Notifications
You must be signed in to change notification settings - Fork 711
Add support for env variables with SFTP client.#1445
Add support for env variables with SFTP client.#1445di-ov wants to merge 12 commits intomscdex:masterfrom
Conversation
This relates to and closes this issue: #1433
I basically saw how this was implemented in the exec() method in client.js and did a similar implementation.
I seems that it might be better to add an additional parameter to the sftp() method, i.e. in client.js it would appear as sftp(env, cb), I wasn't entirely sure, what do you think? Thanks!
|
@mscdex we also would like to have such a solution. |
That would be the preferred approach. |
|
All that's needed now is a unit test. You'll probably have to use one similar to the last one in the SFTP test script to verify the environment is being sent properly before starting the subsystem. |
9db57fe to
3659269
Compare
|
@mscdex I'd also be interested in this solution. Anything that can be done to support this / move this forward? |
|
Is there anything we could do, to speed this up? |
|
Yea, I really need this ASAP , so if we can help you somehow to speed the process let us know |
|
Is this repo still alive @mscdex ? |