-
Notifications
You must be signed in to change notification settings - Fork 0
Conversation
30eb66f to
0a2030c
Compare
MIRACLTrust/MIRACLTrust-Sources/Verification/VerificationConfirmationResponse.swift
Show resolved
Hide resolved
| /// Custom text specified in the MIRACL Trust Portal for the custom verification. | ||
| public let verificationCustomText: String | ||
|
|
||
| /// Label of the identity which will be used for identity verification. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure should I follow the portal or the documentation vocabulary for the terminology but in both places we say User Verification, not Identity Verification. IMO we need to use the same terms everywhere and this is easy to be mixed. Having the fact we have nowhere (at least I don't know) described our terminology, it could be confusing for s.o. what is what.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Having in mind the above, here it should be User ID Type, not Identity Type.
| /// Custom text specified in the MIRACL Trust Portal for the custom verification. | ||
| var verificationCustomText: String { get } | ||
|
|
||
| /// Label of the identity which will be used for identity verification. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's the same here and I won't comment more about the topic as I suppose we need to decide what language to use and how to proceed with the topic further. @Foriger
| // MARK: SDK Configuration | ||
|
|
||
| /// Getting singleton instance of the MIRACLTrust class. | ||
| /// Gets singleton instance of the MIRACLTrust class. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gets a singleton instance.. ?
| /// - Parameter configuration:object storing configurations of the SDK. | ||
| /// Configures the SDK with values issued by MIRACL Trust and stored in the ``Configuration`` object. | ||
| /// It is recommended to call this method after the application is launched. | ||
| /// - Parameter configuration: object storing configurations of the SDK. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
an object storing...?
| /// | ||
| /// Use this method to authenticate another device or application with the usage of | ||
| /// Universal Link created by a MIRACL platform. | ||
| /// Use this method to authenticate another device or application using an |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
**a** universal link is corrected bellow