-
Notifications
You must be signed in to change notification settings - Fork 6.1k
Conversation
Contributor
Description
Migrate amc4th RL training logics.
Motivation and Context
How Has This Been Tested?
- Pass the test by running:
pytest qlib/tests/test_all_pipeline.pyunder upper directory ofqlib. - If you are adding a new feature, test on your own test scripts.
Screenshots of Test Results (if appropriate):
- Pipeline test:
- Your own tests:
Types of changes
- Fix bugs
- Add new feature
- Update documentation
you-n-g
reviewed
Oct 18, 2022
examples/rl/scripts/data_pipeline.sh
Outdated
| python ../../scripts/dump_bin.py dump_all --csv_path ./data/csv --qlib_dir ./data/bin --include_fields open,close,high,low,vwap,volume --symbol_field_name symbol --date_field_name date --freq 1min; | ||
|
|
||
| # Generate pickle format data | ||
| python scripts/gen_pickle_data.py -c scripts/pickle_data_config.yml; |
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we have these semi-colon in this script
Contributor
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's just my personal habit to use semi-colon to separate commands XD. Will remove them.
| import os | ||
| from copy import deepcopy | ||
|
|
||
| from qlib.contrib.data.highfreq_provider import HighFreqProvider |
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please replace print_log in highfreq_provider with qlib.logging.
you-n-g
approved these changes
Oct 19, 2022
ultmaster
approved these changes
Oct 19, 2022
qianyun210603
pushed a commit
to qianyun210603/qlib
that referenced
this pull request
Mar 23, 2023
* Migrate amc4th training
* Refine RL example scripts
* Resolve PR comments
Co-authored-by: luocy16
* Refine RL example scripts
* Resolve PR comments
Co-authored-by: luocy16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.