-
Notifications
You must be signed in to change notification settings - Fork 976
fix: prevent TTL timer from killing session when new consumer reconnects#8461
Merged
mscolnick merged 1 commit intomarimo-team:mainfrom Feb 26, 2026
Merged
fix: prevent TTL timer from killing session when new consumer reconnects#8461mscolnick merged 1 commit intomarimo-team:mainfrom
mscolnick merged 1 commit intomarimo-team:mainfrom
Conversation
Contributor
Summary
When a WebSocket consumer reconnects to an existing session, the previous consumer's TTL close timer was never cancelled and would fire later, destroying the session even though a new consumer was actively connected.
Description of Changes
Unit tests to confirm the issue.
Guard to prevent TTL from closing a session that has a new connection on it.
Checklist
- [ x] I have read the contributor guidelines.
- For large changes, or changes that affect the public API: this change was discussed or approved through an issue, on Discord, or the community discussions (Please provide a link if applicable).
- [ x] Tests have been added for the changes made.
- Documentation has been updated where applicable, including docstrings for API changes.
- [ x] Pull request title is a good summary of the changes - it will be used in the release notes.
When a WebSocket consumer reconnects to an existing session, the previous
consumer's TTL close timer was never cancelled and would fire later,
destroying the session even though a new consumer was actively connected.
consumer's TTL close timer was never cancelled and would fire later,
destroying the session even though a new consumer was actively connected.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
All contributors have signed the CLA |
Contributor
Author
|
I have read the CLA Document and I hereby sign the CLA |
mscolnick
approved these changes
Feb 26, 2026
Contributor
|
thank you @tigretigre for the fix! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.