-
Notifications
You must be signed in to change notification settings - Fork 984
fix: handle objects with __getattr__ returning non-callable values in serialization#8109
Merged
dmadisetti merged 3 commits intomainfrom Feb 4, 2026
Merged
fix: handle objects with __getattr__ returning non-callable values in serialization#8109dmadisetti merged 3 commits intomainfrom
__getattr__ returning non-callable values in serialization#8109dmadisetti merged 3 commits intomainfrom
Conversation
Contributor
Summary
Objects that implement __getattr__ (like rdflib.Namespace) caused serialization errors because hasattr() returns True for any attribute name, but the returned value may not be callable.
Added getcallable() utility function that safely retrieves callable attributes, returning None if the attribute doesn't exist or isn't callable
Closes #8096
...in serialization
### Summary
Objects that implement `__getattr__` (like `rdflib.Namespace`) caused serialization errors because `hasattr()` returns `True` for any attribute name, but the returned value may not be callable.
Added `getcallable()` utility function that safely retrieves callable attributes, returning `None` if the attribute doesn't exist or isn't callable
Closes #8096
### Summary
Objects that implement `__getattr__` (like `rdflib.Namespace`) caused serialization errors because `hasattr()` returns `True` for any attribute name, but the returned value may not be callable.
Added `getcallable()` utility function that safely retrieves callable attributes, returning `None` if the attribute doesn't exist or isn't callable
Closes #8096
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Closed
1 task
Contributor
Author
|
test was fixed and merged to main |
dmadisetti
approved these changes
Feb 4, 2026
|
Development release published. You may be able to view the changes at https://marimo.app?v=0.19.8-dev18 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.