Dark Mode

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

improvement: use vega 6 mimetype, capture screenshots on pdf export#7906

Merged
mscolnick merged 2 commits intomainfrom
ms/vega-6-mimetype
Jan 20, 2026
Merged

improvement: use vega 6 mimetype, capture screenshots on pdf export#7906
mscolnick merged 2 commits intomainfrom
ms/vega-6-mimetype

Conversation

Copy link
Contributor

mscolnick commented Jan 20, 2026 *
edited
Loading

This makes sure we use the correct vega/vegalite mime type (now 6) and well as updates some logic to include also include vega charts when capturing screenshots.

mscolnick requested review from Light2Dark and manzt as code owners January 20, 2026 18:43
Copy link

vercel bot commented Jan 20, 2026 *
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
marimo-docs Ready Preview, Comment Jan 20, 2026 7:36pm

github-actions bot added the bash-focus Area to focus on during release bug bash label Jan 20, 2026
vercel bot deployed to Preview January 20, 2026 18:44 View deployment
mscolnick commented Jan 20, 2026
"application/vnd.vega.v5+json",
"application/vnd.vegalite.v6+json",
"application/vnd.vega.v6+json",
]);
Copy link
Contributor Author

mscolnick Jan 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @Light2Dark for export-to-pdf

Light2Dark reacted with thumbs up emoji
mscolnick added the enhancement New feature or request label Jan 20, 2026
manzt previously approved these changes Jan 20, 2026
Copy link
Collaborator

manzt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Are the vega specs kept in the repr mimebundle for the ipynb exports? I know that is separate from these changes, but some renders will support that directly on top of PNG.

Copy link
Contributor Author

mscolnick commented Jan 20, 2026

@manzt yes, we augment the outputs with the PNG (instead of overwrite)

manzt reacted with thumbs up emoji

Copy link
Collaborator

manzt commented Jan 20, 2026

Great.

Light2Dark previously approved these changes Jan 20, 2026
mscolnick dismissed stale reviews from Light2Dark and manzt via d84c340 January 20, 2026 19:35
vercel bot deployed to Preview January 20, 2026 19:36 View deployment
mscolnick merged commit 90418ca into main Jan 20, 2026
49 of 50 checks passed
mscolnick deleted the ms/vega-6-mimetype branch January 20, 2026 21:24
Copy link

github-actions bot commented Jan 20, 2026

Development release published. You may be able to view the changes at https://marimo.app?v=0.19.5-dev25

botterYosuke pushed a commit to botterYosuke/marimo that referenced this pull request Jan 21, 2026
...arimo-team#7906)

This makes sure we use the correct vega/vegalite mime type (now 6) and
well as updates some logic to include also include vega charts when
capturing screenshots.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Light2Dark Light2Dark left review comments

manzt manzt left review comments

Assignees

No one assigned

Labels

bash-focus Area to focus on during release bug bash enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants