Dark Mode

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Changes in Spectral Layout#993

Open
Sakshi-2797 wants to merge 1 commit intolmcinnes:masterfrom
Sakshi-2797:spectral_layout
Open

Changes in Spectral Layout#993
Sakshi-2797 wants to merge 1 commit intolmcinnes:masterfrom
Sakshi-2797:spectral_layout

Conversation

Copy link

Sakshi-2797 commented Apr 5, 2023 *
edited
Loading

This contribution includes a faster implementation of the spectral_layout function. The implementation replaces the eigenvalue compute with a faster MKL based method. The modification provides a speedup of ~9x in some cases.
Important - This modification is dependent on "libmkl_rt.so" library.

Sakshi-2797 force-pushed the spectral_layout branch 2 times, most recently from 8c9b0ab to a665496 Compare April 5, 2023 08:18
Copy link
Owner

lmcinnes commented Apr 5, 2023

While I appreciate the work, and the speedup would be helpful, I am wary of a new dependency on a binary library like this -- I also note you have an environment variable set that is hardcoded to a path that may not be the install location on some machines, and won't work at all on non-Linux machines.

Sakshi-2797 force-pushed the spectral_layout branch from a665496 to 4b1afe9 Compare April 6, 2023 06:19
Copy link
Author

Sakshi-2797 commented Apr 20, 2023

While I appreciate the work, and the speedup would be helpful, I am wary of a new dependency on a binary library like this -- I also note you have an environment variable set that is hardcoded to a path that may not be the install location on some machines, and won't work at all on non-Linux machines.

Hi @lmcinnes ,
We have made the required changes , the environment variable is changed to a dynamic implementation which will work on the on Linux and non-Linux machines. However , we are facing some issues while raising a PR as some pre commit tests aren't passing. Is there a way to run these tests on local environment?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants