-
Notifications
You must be signed in to change notification settings - Fork 860
Conversation
This contribution includes a faster implementation of the spectral_layout function. The implementation replaces the eigenvalue compute with a faster MKL based method. The modification provides a speedup of ~9x in some cases.
Important - This modification is dependent on "libmkl_rt.so" library.
8c9b0ab to
a665496
Compare
|
While I appreciate the work, and the speedup would be helpful, I am wary of a new dependency on a binary library like this -- I also note you have an environment variable set that is hardcoded to a path that may not be the install location on some machines, and won't work at all on non-Linux machines. |
a665496 to
4b1afe9
Compare
Hi @lmcinnes , |