-
Notifications
You must be signed in to change notification settings - Fork 18
Open
Open
mint-check-translations misses issues with plural strings#27
Description
The checking of plural forms misses some translations issues. For example, this is causing a segfault in my codebase:
msgid "There is %zu provider available for %s\n"
msgid_plural "There are %zu providers available for %s:\n"
msgstr[0] "Za %s je na voljo %zu ponudnik\n"
msgstr[1] "Za %s sta a voljo %zu ponudnika:\n"
msgstr[2] "Za %s so na voljo %zu ponundiki:\n"
msgstr[3] "Za %s je na voljo %zu ponudnikov :\n"
Taking a sledge hammer approach... Removing the following check "fixes" the issue for me - or at least prints issues with msgstr[0]
if (is_plural and not is_python):
# Plural forms don't have to match the number of arguments in C, but they do in Python
return GOOD
While the comment in the code is true, the arguments still need to be provided in the right order. Thus skipping all checks is missing a class of translation bugs.
Metadata
Metadata
Assignees
Labels
No labels