Dark Mode

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

updated BaseOptions.format with explicit format types#286

Open
rscotten wants to merge 1 commit intolindell:masterfrom
rscotten:update-types-baseoptions-format
Open

updated BaseOptions.format with explicit format types#286
rscotten wants to merge 1 commit intolindell:masterfrom
rscotten:update-types-baseoptions-format

Conversation

Copy link

rscotten commented Mar 24, 2019

This PR changes the Typscript typings for BaseOptions.format from string to type Format = 'CODE39 | 'CODE128' | .... This will help us spell and case the formats correctly and give type-hinting from the IDE.

Copy link
Author

rscotten commented Mar 24, 2019

not sure why the first Travis build failed but the others passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant