-
Notifications
You must be signed in to change notification settings - Fork 1.2k
fix(server): filter out /quic in favor of /quic-v1#4467
fix(server): filter out /quic in favor of /quic-v1#4467mergify[bot] merged 8 commits intolibp2p:masterfrom
/quic in favor of /quic-v1#4467Conversation
Description
Configuration files generated by Kubo <= v0.22 list both /quic and /quic-v1 listen addresses with the same UDP port. Given that we enable draft-29, the two addresses are treated the same by rust-libp2p's QUIC implementation. Though calling listen_on with both results in an "Address already in use" error by the OS on the second call. To prevent this from happening filter out /quic addresses in favor of /quic-v1.
Notes & open questions
Change checklist
- I have performed a self-review of my own code
- I have made corresponding changes to the documentation
- I have added tests that prove my fix is effective or that my feature works
- A changelog entry has been made in the appropriate crates
addresses with the same UDP port. Given that we enable draft-29, the two addresses are
treated the same by rust-libp2p's QUIC implementation. Though calling `listen_on` with
both results in an "Address already in use" error by the OS on the second call. To
prevent this from happening filter out `/quic` addresses in favor of `/quic-v1`.
|
@mcamou This disables |
@thomaseizinger sounds good! I think this is what we need. |
This comment was marked as resolved.
This comment was marked as resolved.
mxinden
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you. I find this an easier solution than the one I initially proposed.
I forgot to update the PR description though so the commit message is all wrong :/ |
libp2p#4120 reintroduced it as a faulty merge.
This commit removes it again.