-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Fix matchSubdomain function to correctly handle exact domain matches#2802
Fix matchSubdomain function to correctly handle exact domain matches#2802suwakei wants to merge 2 commits intolabstack:masterfrom
Conversation
Problem
The matchSubdomain function incorrectly returns false for exact domain matches without wildcards--for example, http://example.com vs. http://example.com.
Cause
Even if all parts match during iteration, the function still returns false at the end.
Fix
After the loop, if all parts match and the number of parts is equal between the pattern and the domain, it should return true--i.e., treat it as an exact match.
This PR adds that check.
|
Hi! Just following up to see if there's anything I can improve in this PR |
|
My two cents: |
|
I added specific unit test |
|
Hi maintainers |