-
Notifications
You must be signed in to change notification settings - Fork 2k
Merged
Conversation
AndreMiras
reviewed
Feb 13, 2023
Member
AndreMiras
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR, I left some comments/questions
Comment on lines
+4
to
+11
| class PyAVCodecsRecipe(Recipe): | ||
| depends = ["libx264", "libshine", "libvpx"] | ||
|
|
||
| def build_arch(self, arch): | ||
| pass | ||
|
|
||
|
|
||
| recipe = PyAVCodecsRecipe() |
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this recipe doing anything at all then?
Contributor
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The main intention is to keep the concept between PyAV and FFPyPlayer codecs distinct. That way, if there are any modifications to the PyAV codecs recipe, they will not interfere with FFPyPlayer.
In short, each recipe (PyAV/FFPyPlayer) in its own context.
Co-authored-by: Andre Miras
AndreMiras
approved these changes
Feb 14, 2023
Member
AndreMiras
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks
shyamnathp
pushed a commit
to shyamnathp/python-for-android
that referenced
this pull request
Feb 17, 2023
* pyav recipe
* flake8 fix
* Update pythonforandroid/recipes/av/__init__.py
Co-authored-by: Andre Miras
---------
Co-authored-by: Andre Miras
* flake8 fix
* Update pythonforandroid/recipes/av/__init__.py
Co-authored-by: Andre Miras
---------
Co-authored-by: Andre Miras
misl6
added a commit
that referenced
this pull request
May 22, 2023
* Add support for Python 3.10 and make it the default while building hostpython3 and python3 (#2577)
* Add support for Python 3.10 and make it the default while building hostpython3 and python3
* Update bugfix version
* Add PyAV recipe (#2750)
* pyav recipe
* flake8 fix
* Update pythonforandroid/recipes/av/__init__.py
Co-authored-by: Andre Miras
---------
Co-authored-by: Andre Miras
* Add debug loggings for identifying a matching dist (#2751)
* Add debug loggings for identifying a matching dist
* Fix lint failure on f-string.
* Adds flag to support home app (launcher) intent-filter on SDL2 bootstrap (#2761)
* Home app functionality
* Cleanup
* Added --home-app to the docs
* Fixed the if statements within the intent-filter
* Use io.IOBase for LogFile (#2763)
This provides reasonable default implementations for common IO class
methods such as isatty().
Closes #2762.
* android_api to integer (#2765)
* android_api to integer
* changes to android_api
* changes to android_api
* fix #2768 smallIconName null can t be compared to String (#2769)
* fix #2768 smallIconName null can t be compared to String
* fix: Remove Importance None of notification which is modification from my own fork
* fix: Readd Importance_NONE in the notification channel as it s also in upstream p4a
* fix tools/liblink: syntax error
regression from 22b7dfe
* Update pyjnius version in recipe (#2791)
* Update Kivy recipe for 2.2.0 (#2793)
* Update Kivy recipe for 2.2.0rc1
* Bump to 2.2.0
* Update CHANGELOG.md and bump version to 2023.05.21
---------
Co-authored-by: Dexer <73297572+DexerBR@users.noreply.github.com>
Co-authored-by: Andre Miras
Co-authored-by: BitcoinWukong <87334822+BitcoinWukong@users.noreply.github.com>
Co-authored-by: Mathias Lindstrom
Co-authored-by: Dylan McCall
Co-authored-by: Benoit HERVIER
Co-authored-by: SomberNight
* Add support for Python 3.10 and make it the default while building hostpython3 and python3
* Update bugfix version
* Add PyAV recipe (#2750)
* pyav recipe
* flake8 fix
* Update pythonforandroid/recipes/av/__init__.py
Co-authored-by: Andre Miras
---------
Co-authored-by: Andre Miras
* Add debug loggings for identifying a matching dist (#2751)
* Add debug loggings for identifying a matching dist
* Fix lint failure on f-string.
* Adds flag to support home app (launcher) intent-filter on SDL2 bootstrap (#2761)
* Home app functionality
* Cleanup
* Added --home-app to the docs
* Fixed the if statements within the intent-filter
* Use io.IOBase for LogFile (#2763)
This provides reasonable default implementations for common IO class
methods such as isatty().
Closes #2762.
* android_api to integer (#2765)
* android_api to integer
* changes to android_api
* changes to android_api
* fix #2768 smallIconName null can t be compared to String (#2769)
* fix #2768 smallIconName null can t be compared to String
* fix: Remove Importance None of notification which is modification from my own fork
* fix: Readd Importance_NONE in the notification channel as it s also in upstream p4a
* fix tools/liblink: syntax error
regression from 22b7dfe
* Update pyjnius version in recipe (#2791)
* Update Kivy recipe for 2.2.0 (#2793)
* Update Kivy recipe for 2.2.0rc1
* Bump to 2.2.0
* Update CHANGELOG.md and bump version to 2023.05.21
---------
Co-authored-by: Dexer <73297572+DexerBR@users.noreply.github.com>
Co-authored-by: Andre Miras
Co-authored-by: BitcoinWukong <87334822+BitcoinWukong@users.noreply.github.com>
Co-authored-by: Mathias Lindstrom
Co-authored-by: Dylan McCall
Co-authored-by: Benoit HERVIER
Co-authored-by: SomberNight
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.