-
Notifications
You must be signed in to change notification settings - Fork 2k
Merged
Conversation
keep sh version under 2.0 as default behaviour was switched
Contributor
Author
misl6
approved these changes
Feb 10, 2023
Member
misl6
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for explaining!
Let's wait for the CI pipeline to complete, but LGTM.
I guess we should have an emergency release this weekend.
I will then open an issue to remind us that sh.Command usage should be migrated to be future-proof.
5 tasks
misl6
added a commit
that referenced
this pull request
Feb 11, 2023
* Update `pydantic` recipe
There is [incompatibility](huggingface/transformers#8638) between python > 3.6 and package `dataclasses`.
This error was happening after my compilations: `AttributeError: module 'typing' has no attribute '_ClassVar'`
The fix is removing `dataclasses` from `python_depends`.
I also updated the pydantic version to the newest release `1.10.4`, it can be checked [here](https://github.com/pydantic/pydantic/releases) and its url.
I already compiled my app after applying these changes, and the compilation is working successfully again.
* Restrict sh version to sh>=1.10, <2.0 (#2746)
keep sh version under 2.0 as default behaviour was switched
* Update CHANGELOG.md and update version to 2023.02.10
---------
Co-authored-by: Filipe Marchesini
Co-authored-by: Andre Miras
Co-authored-by: HyTurtle <81598434+HyTurtle@users.noreply.github.com>
There is [incompatibility](huggingface/transformers#8638) between python > 3.6 and package `dataclasses`.
This error was happening after my compilations: `AttributeError: module 'typing' has no attribute '_ClassVar'`
The fix is removing `dataclasses` from `python_depends`.
I also updated the pydantic version to the newest release `1.10.4`, it can be checked [here](https://github.com/pydantic/pydantic/releases) and its url.
I already compiled my app after applying these changes, and the compilation is working successfully again.
* Restrict sh version to sh>=1.10, <2.0 (#2746)
keep sh version under 2.0 as default behaviour was switched
* Update CHANGELOG.md and update version to 2023.02.10
---------
Co-authored-by: Filipe Marchesini
Co-authored-by: Andre Miras
Co-authored-by: HyTurtle <81598434+HyTurtle@users.noreply.github.com>
shyamnathp
pushed a commit
to shyamnathp/python-for-android
that referenced
this pull request
Feb 17, 2023
keep sh version under 2.0 as default behaviour was switched
manuq
pushed a commit
to endlessm/python-for-android
that referenced
this pull request
Feb 17, 2023
keep sh version under 2.0 as default behaviour was switched
accumulator
pushed a commit
to accumulator/python-for-android
that referenced
this pull request
Feb 27, 2023
keep sh version under 2.0 as default behaviour was switched
accumulator
pushed a commit
to accumulator/python-for-android
that referenced
this pull request
Feb 27, 2023
Restrict sh version to sh>=1.10, <2.0 (kivy#2746)
keep sh version under 2.0 as default behaviour was switched
keep sh version under 2.0 as default behaviour was switched
AndreMiras
added a commit
that referenced
this pull request
Aug 13, 2024
AndreMiras
added a commit
that referenced
this pull request
Aug 16, 2024
AndreMiras
added a commit
that referenced
this pull request
Aug 16, 2024
AndreMiras
added a commit
that referenced
this pull request
Aug 16, 2024
Bump sh module to v2, refs #2746
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.