Dark Mode

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

requirements: relax version bound on "pep517"#2680

Merged
misl6 merged 1 commit intokivy:developfrom
SomberNight:202210_deps_pep517
Oct 6, 2022
Merged

requirements: relax version bound on "pep517"#2680
misl6 merged 1 commit intokivy:developfrom
SomberNight:202210_deps_pep517

Conversation

Copy link
Contributor

SomberNight commented Oct 5, 2022

The "<0.7.0" bound was added in 9f6d6fc to fix #1994 :

The TestGetSystemPythonExecutable.test_virtualenv and TestGetSystemPythonExecutable.test_venv tests started failing all of a sudden. Error was:

ModuleNotFoundError: No module named \'pytoml\'\n'

This ca be reproduced in local via:

pytest tests/test_pythonpackage_basic.py::TestGetSystemPythonExecutable::test_virtualenv

I think this no longer applies,
$ pytest tests/test_pythonpackage_basic.py::TestGetSystemPythonExecutable runs successfully for me, using latest pep517==0.13.0.

Also, let's see if the CI tests pass.
The "<0.7.0" bound was added in kivy@9f6d6fc
to fix kivy#1994 :

> The `TestGetSystemPythonExecutable.test_virtualenv` and `TestGetSystemPythonExecutable.test_venv` tests started failing all of a sudden. Error was:
>
> ```
> ModuleNotFoundError: No module named \'pytoml\'\n'
> ```
>
> This ca be reproduced in local via:
>
> ```shell
> pytest tests/test_pythonpackage_basic.py::TestGetSystemPythonExecutable::test_virtualenv
> ```

I think this no longer applies,
`$ pytest tests/test_pythonpackage_basic.py::TestGetSystemPythonExecutable`
runs successfully for me, using latest `pep517==0.13.0`.
Copy link
Member

misl6 commented Oct 5, 2022

Fixes #2573

misl6 linked an issue Oct 5, 2022 that may be closed by this pull request
misl6 approved these changes Oct 5, 2022
Copy link
Member

misl6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's wait for the CI to complete, but LGTM.
Thank you!

misl6 merged commit 25f3a53 into kivy:develop Oct 6, 2022
SomberNight added a commit to SomberNight/python-for-android that referenced this pull request Oct 10, 2022
The "<0.7.0" bound was added in kivy@9f6d6fc
to fix kivy#1994 :

> The `TestGetSystemPythonExecutable.test_virtualenv` and `TestGetSystemPythonExecutable.test_venv` tests started failing all of a sudden. Error was:
>
> ```
> ModuleNotFoundError: No module named \'pytoml\'\n'
> ```
>
> This ca be reproduced in local via:
>
> ```shell
> pytest tests/test_pythonpackage_basic.py::TestGetSystemPythonExecutable::test_virtualenv
> ```

I think this no longer applies,
`$ pytest tests/test_pythonpackage_basic.py::TestGetSystemPythonExecutable`
runs successfully for me, using latest `pep517==0.13.0`.
SomberNight added a commit to SomberNight/python-for-android that referenced this pull request Oct 14, 2022
The "<0.7.0" bound was added in kivy@9f6d6fc
to fix kivy#1994 :

> The `TestGetSystemPythonExecutable.test_virtualenv` and `TestGetSystemPythonExecutable.test_venv` tests started failing all of a sudden. Error was:
>
> ```
> ModuleNotFoundError: No module named \'pytoml\'\n'
> ```
>
> This ca be reproduced in local via:
>
> ```shell
> pytest tests/test_pythonpackage_basic.py::TestGetSystemPythonExecutable::test_virtualenv
> ```

I think this no longer applies,
`$ pytest tests/test_pythonpackage_basic.py::TestGetSystemPythonExecutable`
runs successfully for me, using latest `pep517==0.13.0`.
accumulator pushed a commit to accumulator/python-for-android that referenced this pull request Oct 18, 2022
The "<0.7.0" bound was added in kivy@9f6d6fc
to fix kivy#1994 :

> The `TestGetSystemPythonExecutable.test_virtualenv` and `TestGetSystemPythonExecutable.test_venv` tests started failing all of a sudden. Error was:
>
> ```
> ModuleNotFoundError: No module named \'pytoml\'\n'
> ```
>
> This ca be reproduced in local via:
>
> ```shell
> pytest tests/test_pythonpackage_basic.py::TestGetSystemPythonExecutable::test_virtualenv
> ```

I think this no longer applies,
`$ pytest tests/test_pythonpackage_basic.py::TestGetSystemPythonExecutable`
runs successfully for me, using latest `pep517==0.13.0`.
accumulator pushed a commit to accumulator/python-for-android that referenced this pull request Jan 5, 2023
The "<0.7.0" bound was added in kivy@9f6d6fc
to fix kivy#1994 :

> The `TestGetSystemPythonExecutable.test_virtualenv` and `TestGetSystemPythonExecutable.test_venv` tests started failing all of a sudden. Error was:
>
> ```
> ModuleNotFoundError: No module named \'pytoml\'\n'
> ```
>
> This ca be reproduced in local via:
>
> ```shell
> pytest tests/test_pythonpackage_basic.py::TestGetSystemPythonExecutable::test_virtualenv
> ```

I think this no longer applies,
`$ pytest tests/test_pythonpackage_basic.py::TestGetSystemPythonExecutable`
runs successfully for me, using latest `pep517==0.13.0`.
accumulator pushed a commit to accumulator/python-for-android that referenced this pull request Jan 5, 2023
The "<0.7.0" bound was added in kivy@9f6d6fc
to fix kivy#1994 :

> The `TestGetSystemPythonExecutable.test_virtualenv` and `TestGetSystemPythonExecutable.test_venv` tests started failing all of a sudden. Error was:
>
> ```
> ModuleNotFoundError: No module named \'pytoml\'\n'
> ```
>
> This ca be reproduced in local via:
>
> ```shell
> pytest tests/test_pythonpackage_basic.py::TestGetSystemPythonExecutable::test_virtualenv
> ```

I think this no longer applies,
`$ pytest tests/test_pythonpackage_basic.py::TestGetSystemPythonExecutable`
runs successfully for me, using latest `pep517==0.13.0`.
accumulator pushed a commit to accumulator/python-for-android that referenced this pull request Jan 6, 2023
The "<0.7.0" bound was added in kivy@9f6d6fc
to fix kivy#1994 :

> The `TestGetSystemPythonExecutable.test_virtualenv` and `TestGetSystemPythonExecutable.test_venv` tests started failing all of a sudden. Error was:
>
> ```
> ModuleNotFoundError: No module named \'pytoml\'\n'
> ```
>
> This ca be reproduced in local via:
>
> ```shell
> pytest tests/test_pythonpackage_basic.py::TestGetSystemPythonExecutable::test_virtualenv
> ```

I think this no longer applies,
`$ pytest tests/test_pythonpackage_basic.py::TestGetSystemPythonExecutable`
runs successfully for me, using latest `pep517==0.13.0`.
shyamnathp pushed a commit to shyamnathp/python-for-android that referenced this pull request Feb 17, 2023
The "<0.7.0" bound was added in kivy@9f6d6fc
to fix kivy#1994 :

> The `TestGetSystemPythonExecutable.test_virtualenv` and `TestGetSystemPythonExecutable.test_venv` tests started failing all of a sudden. Error was:
>
> ```
> ModuleNotFoundError: No module named \'pytoml\'\n'
> ```
>
> This ca be reproduced in local via:
>
> ```shell
> pytest tests/test_pythonpackage_basic.py::TestGetSystemPythonExecutable::test_virtualenv
> ```

I think this no longer applies,
`$ pytest tests/test_pythonpackage_basic.py::TestGetSystemPythonExecutable`
runs successfully for me, using latest `pep517==0.13.0`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

misl6 misl6 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[PEP 517] Relax installation-time "pep517<0.7.0" requirement TestGetSystemPythonExecutable.test_virtualenv test fail

2 participants