Dark Mode

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Comments

Update to AssertJ 4.0#4653

Draft
marcphilipp wants to merge 4 commits intomainfrom
marc/assertj-4.0
Draft

Update to AssertJ 4.0#4653
marcphilipp wants to merge 4 commits intomainfrom
marc/assertj-4.0

Conversation

Copy link
Member

marcphilipp commented Jun 17, 2025

Overview

Try out AssertJ 4.0 prior to its release.


I hereby agree to the terms of the JUnit Contributor License Agreement.


Definition of Done

marcphilipp self-assigned this Jun 17, 2025
scordio mentioned this pull request Jun 17, 2025
6 tasks
marcphilipp added the type: task label Jun 22, 2025
scordio reviewed Aug 4, 2025
asciidoctorj-pdf = "2.3.19"
asciidoctor-plugins = "4.0.4" # Check if workaround in documentation.gradle.kts can be removed when upgrading
assertj = "3.27.3"
assertj = "4.0.0-M1"
Copy link
Contributor

scordio Aug 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We now publish snapshots:

Suggested change
assertj = "4.0.0-M1"
assertj = "4.0.0-SNAPSHOT"

Copy link
Member Author

marcphilipp Aug 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! You don't publish snapshot Javadoc anywhere, do you?

Copy link
Contributor

scordio Aug 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I'm not mistaken, the Javadoc JAR also gets generated and published to Maven Central, but I don't know how its content could be consumed/linked.

As part of version 4 work, I plan to publish the Javadoc also to our own domain to relax a bit the dependency to javadoc.io, and the new publishing will also include snapshot content.

marcphilipp reacted with thumbs up emoji
marcphilipp force-pushed the marc/assertj-4.0 branch from 25a3aa0 to 8911274 Compare August 11, 2025 09:31
Copy link
Member Author

marcphilipp commented Aug 11, 2025

Looks like xmlunit needs to be adjusted due to assertj/assertj@989faf8

Copy link
Contributor

scordio commented Aug 11, 2025

Looks like xmlunit needs to be adjusted due to assertj/assertj@989faf8

Thanks for the heads up! We'll reach out to the project about it.

marcphilipp reacted with thumbs up emoji

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

scordio scordio left review comments

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants