-
Notifications
You must be signed in to change notification settings - Fork 79
Conversation
Contributor
Funders and paymasters needed a nonce to prevent accounts from replaying intents on paymasters and funders
This created a bunch of nonce invalidation duplication - the paymaster, funder and account all needed to invalidate their own nonce because they cant trust each other
Moving this to the OC allows us to get away with just invalidating a single nonce. This reduces gas by:
- ~1k for all flows
- ~22k for all app sponsor flows
- another ~22k reduction for funder flows (not captured in benchmarks)
Contributor
|
Bytecode changes detected! EIP-712 domain versions have been automatically updated for: IthacaAccount,Orchestrator,SimpleFunder |
howydev
force-pushed
the
howy/update-benchmarks
branch
from
October 9, 2025 05:04
7ea2e15 to
ed932e5
Compare
* feat: simplify multichain nonce design
* chore: readd merkle verification prefix
* chore: undo blank line addns
* chore: lint
* .
* ~50 failing tests down to 5
* down to 1 failing test
* fixed failing test
* chore: remove console logs and bench
* .
* Update test/Base.t.sol
* Update src/Orchestrator.sol
* Update test/utils/mocks/MockPayerWithSignatureOptimized.sol
* chore: final cleanup, rebench
* Update src/Orchestrator.sol
* chore: bump contract versions due to bytecode changes - Contracts updated: IthacaAccount,Orchestrator,SimpleFunder,Simulator
* chore: cleanup
* rebase
* fix
---------
Co-authored-by: GitHub Action
* chore: readd merkle verification prefix
* chore: undo blank line addns
* chore: lint
* .
* ~50 failing tests down to 5
* down to 1 failing test
* fixed failing test
* chore: remove console logs and bench
* .
* Update test/Base.t.sol
* Update src/Orchestrator.sol
* Update test/utils/mocks/MockPayerWithSignatureOptimized.sol
* chore: final cleanup, rebench
* Update src/Orchestrator.sol
* chore: bump contract versions due to bytecode changes - Contracts updated: IthacaAccount,Orchestrator,SimpleFunder,Simulator
* chore: cleanup
* rebase
* fix
---------
Co-authored-by: GitHub Action
howydev
force-pushed
the
howy/orchestrator-nonce
branch
from
October 9, 2025 05:18
893c356 to
d50a531
Compare
...ated: IthacaAccount,Orchestrator,SimpleFunder
Contributor
|
Bytecode changes detected! EIP-712 domain versions have been automatically updated for: IthacaAccount,Orchestrator,SimpleFunder |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.