-
Notifications
You must be signed in to change notification settings - Fork 18
Conversation
This addition disallows developers from using functions, while keeping the ability to use namespaces and constants.
Special thanks to @jrfnl for building this ruleset for us and making this so easy to use!
use functionuse function and use const
| "minimum-stability": "dev", | ||
| "prefer-stable": true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are these changes intentional? Neither of them will have any effect if the project isn't the root project.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They were, yes. phpcsextra is only released as alpha and it wouldn't install without adding these in: https://github.com/PHPCSStandards/PHPCSExtra/releases
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, we'll have to hold on releasing this then until phpcsextra is released, as the minimum-stability won't flow through, and would make the coding standards uninstallable as a dependency.
|
Requested a stable release: PHPCSStandards/PHPCSExtra#91 |