-
Notifications
You must be signed in to change notification settings - Fork 833
security: remove hardcoded Codecov token from .codecov.yml#3620
Merged
vangent merged 1 commit intogoogle:masterfrom Sep 23, 2025
wadgamaraldeen:fix/codecov-token-leak
Merged
security: remove hardcoded Codecov token from .codecov.yml#3620vangent merged 1 commit intogoogle:masterfrom wadgamaraldeen:fix/codecov-token-leak
vangent merged 1 commit intogoogle:masterfrom
wadgamaraldeen:fix/codecov-token-leak
Conversation
Contributor
Summary
This PR removes a hardcoded Codecov upload token from .codecov.yml and replaces it with documentation advising the use of CI-provided secrets.
Rationale
Storing tokens in version control exposes them to anyone with read access to the repository, which can allow unauthorized uploads to the project's Codecov dashboard. This could be abused to:
- Upload forged coverage reports.
- Inflate/deflate project coverage metrics.
- Pollute project history and reduce trust in CI/CD data.
Security Benefits
- Prevents unauthorized manipulation of coverage data.
- Aligns the project with best practices for secret management.
- Reduces the risk of future supply-chain or CI/CD integrity issues.
References
Signed-off-by: Mustafa Adam ibnqamar10@gmail.com
Signed-off-by: wadgamaraldeen
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.