-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Conversation
DESCRIBE YOUR PR
Document the now-functional useShakeGesture option for Apple/Cocoa user feedback, based on sentry-cocoa#7579.
- Add "Shake to Report" section to the user feedback setup page with a Swift example
- Update
useShakeGestureconfig description to note it's iOS-only (no-op on macOS, tvOS, watchOS, visionOS)
IS YOUR CHANGE URGENT?
Help us prioritize incoming PRs by letting us know when the change needs to go live.
- Urgent deadline (GA date, etc.):
- Other deadline:
- None: Not urgent, can wait up to 1 week+
SLA
- Teamwork makes the dream work, so please add a reviewer to your PRs.
- Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it.
Thanks in advance for your help!
PRE-MERGE CHECKLIST
Make sure you've checked the following before merging your changes:
- Checked Vercel preview for correctness, including links
- PR was reviewed and approved by any necessary SMEs (subject matter experts)
- PR was reviewed and approved by a member of the Sentry docs team
Co-Authored-By: Claude noreply@anthropic.com
the `useShakeGesture` config description to note it's iOS-only.
Ref: getsentry/sentry-cocoa#7579
Co-Authored-By: Claude
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
philprime
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
| | ------------------------ | --------------- | ------- | ------------------------------------------------------------ ------------------------------------------------------------ ---------------------------------- | | ||
| | `animations` | `Bool` | `true` | Whether or not to show animations, like for presenting and dismissing the form. | | ||
| | `useShakeGesture` | `Bool` | `false` | Use a shake gesture to display the form. | | ||
| | `useShakeGesture` | `Bool` | `false` | Use a shake gesture to display the form. Only supported on iOS; this is a no-op on macOS, tvOS, watchOS, and visionOS. | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Technically iPadOS too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch. Updated with db3a8a3