Dark Mode

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

docs: add example on how to use testing-library with typescript#990

Draft
shadowusr wants to merge 1 commit intomasterfrom
users/shadowusr/TESTPLANE-5.testing-library-example
Draft

docs: add example on how to use testing-library with typescript#990
shadowusr wants to merge 1 commit intomasterfrom
users/shadowusr/TESTPLANE-5.testing-library-example

Conversation

Copy link
Member

shadowusr commented Aug 7, 2024

No description provided.

shadowusr marked this pull request as draft August 9, 2024 11:55
DudaGod reviewed Aug 9, 2024
Copy link
Member

DudaGod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this example really work? Because I don't see testplane config and open url in test example. Looks like it should not work. Can we fix it?

@@ -0,0 +1,20 @@
{
"name": "m-t-l-e",
Copy link
Member

DudaGod Aug 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does it mean? Why not just use folder name?

"description": "",
"main": "index.js",
"scripts": {
"test": "echo \"Error: no test specified\" && exit 1"
Copy link
Member

DudaGod Aug 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe we should add a testplane launch here?

@@ -0,0 +1,16 @@
import type {} from "testplane";
Copy link
Member

DudaGod Aug 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is it for? Mistake or some hack?


it("example", async ({browser}) => {
// testing library matcher
await expect(browser.$("some elem")).toContainHTML("some html");
Copy link
Member

DudaGod Aug 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, I don't understand where code with open some url?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

DudaGod DudaGod left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants