Dark Mode

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Update toolbox.adoc#117

Open
thomas-saigre wants to merge 2 commits intofeelpp:masterfrom
thomas-saigre:patch-1
Open

Update toolbox.adoc#117
thomas-saigre wants to merge 2 commits intofeelpp:masterfrom
thomas-saigre:patch-1

Conversation

Copy link
Contributor

thomas-saigre commented Apr 29, 2020

Give a better description of the export of the drag and lift forces (I hope it will be sharper...)

prudhomm reacted with thumbs up emoji
Give a better description of the export of the drag and lift forces (I hope it will be sharper...)
prudhomm requested a review from vincentchabannes April 30, 2020 06:51
prudhomm assigned thomas-saigre Apr 30, 2020
prudhomm self-requested a review April 30, 2020 06:51
Copy link
Member

prudhomm commented Apr 30, 2020

drag and lift are misnamed, they would require having the direction of the flow and the direction of motion. Forces computes the surfacic forces (F_x, F_y) applied by the fluid to the object. It would be drag and lift if the flow or motion is aligned with the x-axis

prudhomm requested changes Apr 30, 2020
Copy link
Member

prudhomm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be possible to remove the notion of drag and lift but add a TIP saying that the forces correspond to the drag and lift of the fluid or object motion is aligned with the x-axis ?


==== Forces
compute lift and drag
Compute lift and drag
Copy link
Member

prudhomm Apr 30, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

drag and lift are misnamed, they would require having the direction of the flow and the direction of motion. Forces computes the surfacic forces (F_x, F_y) applied by the fluid to the object. It would be drag and lift if the flow or motion is aligned with the x-axis

Copy link
Member

prudhomm Apr 30, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vincentchabannes probably a discussion on forces should be done in http://docs.feelpp.org/toolboxes/0.108/cfd/theory/

Where `markerX` are the markers of where we want to compute the forces. The results will be given in a csv file whith those columns :

- time
- drag_marker1
Copy link
Member

prudhomm Apr 30, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think drag and lift should be removed here until we provide a direction of flow or motion

Copy link

github-actions bot commented Jan 10, 2022

Stale pull request message

github-actions bot added the no-pr-activity label Jan 10, 2022
Copy link
Member

prudhomm commented Mar 27, 2022

@thomas-saigre could we finish this?

Copy link
Contributor Author

thomas-saigre commented Mar 27, 2022

I do not remember what I was trying to explain here... I think it was about exports for practical work during M1 year, but it's been a while since I last used cfd toolbox...

github-actions bot removed the no-pr-activity label Mar 28, 2022
Copy link

github-actions bot commented Apr 3, 2023

Stale pull request message

github-actions bot added the no-pr-activity label Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

prudhomm prudhomm requested changes

vincentchabannes Awaiting requested review from vincentchabannes

Requested changes must be addressed to merge this pull request.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants