Dark Mode

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Implement sso#1130

Draft
evroon wants to merge 5 commits intomasterfrom
implement-sso
Draft

Implement sso#1130
evroon wants to merge 5 commits intomasterfrom
implement-sso

Conversation

Copy link
Owner

evroon commented Feb 23, 2025 *
edited
Loading

Implements Single Sign-On as feature, next to password login.

Copy link

vercel bot commented Feb 23, 2025 *
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git /

Name Status Preview Comments Updated (UTC)
bracket Ready (Inspect) Visit Preview Add feedback May 23, 2025 3:03pm

vercel bot deployed to Preview February 23, 2025 12:15 View deployment
Copy link

codecov bot commented Feb 23, 2025 *
edited
Loading

Codecov Report

Attention: Patch coverage is 66.66667% with 23 lines in your changes missing coverage. Please review.

Project coverage is 94.18%. Comparing base (c486862) to head (8ee53a0).
Report is 30 commits behind head on master.

Files with missing lines Patch % Lines
backend/bracket/logic/sso.py 44.82% 16 Missing
backend/bracket/routes/auth.py 50.00% 7 Missing
Additional details and impacted files
@@ Coverage Diff @@
## master #1130 +/- ##
==========================================
- Coverage 94.62% 94.18% -0.44%
==========================================
Files 118 120 +2
Lines 4352 4420 +68
==========================================
+ Hits 4118 4163 +45
- Misses 234 257 +23

View full report in Codecov by Sentry.
Have feedback on the report? Share it here.

New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

vercel bot deployed to Preview February 23, 2025 12:17 View deployment
vercel bot deployed to Preview February 23, 2025 12:27 View deployment
Copy link
Contributor

github-actions bot commented Mar 29, 2025

This PR is stale because it has been open for 45 days with no activity. Remove the stale label or comment or this will be closed in 30 days.

github-actions bot added the Stale label Mar 29, 2025
evroon removed the Stale label Mar 29, 2025
Copy link

CraptainCrunch commented May 7, 2025

Hello, I'm new to software development and was wondering if you could explain to me the benefits you are looking for by offering SSO?

Copy link
Owner Author

evroon commented May 7, 2025

Welcome :). Basically:

  • the less passwords you have, the less passwords can be leaked
  • you dont need to remember your password
  • you can sign up and sign in with one click (or zero with Google One Tap) and dont have to fill in the same information every time (name, email, password etc)
  • in the case of google, google will tell you whether the email is verified or not, so you don't have to implement an additional email verification step
  • SSO providers can provide you with group info. So you can for example know whether a user should be an admin or not based on the information the SSO provider provides (but of course that needs to be configured in Bracket)

vercel bot deployed to Preview May 23, 2025 15:03 View deployment
Copy link

Shynixn commented Jun 16, 2025

Hopefully this is merged soon :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants