-
-
Notifications
You must be signed in to change notification settings - Fork 33
Conversation
Contributor
Prerequisites checklist
- I have read the contributing guidelines.
What is the purpose of this pull request?
Adds Knip to check for unused exports, unused dependencies, and missing dependencies
What changes did you make? (Give an overview)
- Added
knip.jsonconfig and a rootlint:unusedscript. - Added a "Lint Files, Dependencies, & Exports" step to our CI.
- Removed unused
BASELINE_FALSEexport
Related Issues
Is there anything you'd like reviewers to focus on?
Contributor
|
Hi everyone, it looks like we lost track of this pull request. Please review and see what the next steps are. This pull request will auto-close in 7 days without an update. |
DMartens
reviewed
Feb 11, 2026
nzakas
previously approved these changes
Feb 16, 2026
Member
nzakas
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Would like @DMartens to verify his feedback has been addressed before merging.
lumirlumir
added
the
accepted
There is consensus among the team that this change meets the criteria for inclusion
label
Feb 20, 2026
DMartens
previously approved these changes
Feb 20, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes LGTM, thanks (left open as a review from the TSC was requested).
Contributor
|
Hi @Pixel998, could you take a look at the conflicts? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.