Dark Mode

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Further typing tightening/modernization#129

Merged
rufuspollock merged 13 commits intodatopian:mainfrom
lsst-sqre:tickets/DM-42231
Jan 12, 2024
Merged

Further typing tightening/modernization#129
rufuspollock merged 13 commits intodatopian:mainfrom
lsst-sqre:tickets/DM-42231

Conversation

Copy link
Collaborator

athornton commented Jan 5, 2024

Consolidating everything into pyproject.toml and making checks stricter.

Not much functional difference, but I'll explain what's going on:

  1. When we move to Ruff it's going to complain about Optional[type] since it prefers type|None, and I'm getting ahead of that.
  2. to do dynamic versioning requires git in the runtime container, so I added it.
  3. moved requirements to a subdirectory to reduce visual clutter for me.
  4. I don't know if the old PreAuthorizingTransferAdapter would have behaved correctly if you'd instantiated multiple subclasses, but there was a lot of shadowing going on at the very least with the handler being a class variable, so I made it also an instance variable and called super().init() from its subclasses. Because it inherits from ABC I probably don't need the @AbstractMethod decorator I have; the point is PreAuthorizingTransferAdapter should never be instantiated on its own, only as a superclass of the transfer adapter you are actually using.
  5. Scope was initializing its fields as both class and instance variables; removed the class variables.
  6. Removed release target from Makefile; for now I can build and push new containers manually, and eventually we will manage that from GitHub, and PyPi and Docker builds will be and stay in sync, release versions driven from Git tags.

athornton mentioned this pull request Jan 9, 2024
Copy link
Member

rufuspollock commented Jan 12, 2024

LGTM.

rufuspollock merged commit e2dad47 into datopian:main Jan 12, 2024
athornton deleted the tickets/DM-42231 branch January 12, 2024 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants