-
Notifications
You must be signed in to change notification settings - Fork 49
feat: update dependencies to use local paths instead of git sources#3105
feat: update dependencies to use local paths instead of git sources#3105QuantumExplorer wants to merge 1 commit intochore/core-worksfrom
Conversation
Issue being fixed or feature implemented
This update changes the dependency management for several packages to use local paths instead of fetching from a remote Git repository.
What was done?
- Updated
Cargo.tomlfiles across multiple packages to replace Git dependencies with local paths fordashcore,dash-spv,key-wallet, andkey-wallet-manager. - Removed the Git source URLs for the
dashcorelibrary and its related packages. - Added a new initializer in the Swift
Walletclass to manage ownership of FFI wallet handles.
How Has This Been Tested?
The changes have been tested by building the project and running existing unit tests to ensure that the local paths resolve correctly and that functionality remains intact.
Breaking Changes
None
Checklist
-
I have performed a self-review of my own code
-
I have commented my code, particularly in hard-to-understand areas
-
I have added or updated relevant unit/integration/functional/e2e tests
For repository code-owners and collaborators only
-
I have assigned this pull request to a milestone
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Use the checkbox below for a quick retry:
Finishing TouchesGenerate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
lklimek
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This breaks way too much stuff when doing a build. We cannot refer do another repos by local path, as it is not guaranteed these are checked out.