-
-
Notifications
You must be signed in to change notification settings - Fork 3.8k
feat(services): add architecture warning#8390
Open
Cinzya wants to merge 2 commits intocoollabsio:nextfrom
Open
feat(services): add architecture warning#8390Cinzya wants to merge 2 commits intocoollabsio:nextfrom
Cinzya wants to merge 2 commits intocoollabsio:nextfrom
Conversation
Member
Changes
Add warning label together with a tooltip to the service list about architectural limitations of a service template.
Issues
Category
- New feature
Screenshots or Video (if applicable)
AI Usage
- AI is used in the process of creating this PR
Steps to Test
- Step 1 - Regenerate service template JSON (
php artisan generate:services) - Step 2 - Search for
Calcomin the Global search - Step 3 - Search for
Calcomin Service List
Contributor Agreement
Important
- I have read and understood the contributor guidelines. If I have failed to follow any guideline, I understand that this PR may be closed without review.
- I have tested the changes thoroughly and am confident that they will work as expected without issues when the maintainer tests them
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.