-
Notifications
You must be signed in to change notification settings - Fork 394
docs: add reference to default options list#680
docs: add reference to default options list#680hesreallyhim wants to merge 5 commits intocharmbracelet:mainfrom
Conversation
- I have read
CONTRIBUTING.md. - [-]
I have created a discussion that was approved by a maintainer (for new features).(docs-only)
I found myself looking through the code to find the default values for various Options settings, so I thought it would be helpful to provide the user with a list of these settings in the README. So as to make the smallest visible change to the existing docs, I added a link in the README to a new Markdown table I assembled (with LLM assistance) based off of the info in vhs.go and related files like styles.go.
If you want to "check my work" there is a file in 037d437 which contains a CSV file I built up to compile the information including line references for the different settings.
Thanks, this library is amazing!
(Partially?) Fixes: #638
(Partially?) Fixes: #495 (duplicate)
|
I think that ideally, the setting, description and default should be in the same table where possible. |
I just did it this way for minimal disturbance to the main README. |
The problem I had with this to start is that you have to look in two places for the information. This simplifies the two places, but it remains at two. The 'what is the default' question is now answered by:
|
|
@joshka maybe I could put the defaults table inside a disclosure element. I'm open to whatever, and totally respect your opinion but also want to hear from a codeowner |