-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Fix bar overlap bug when tick fit is false#2306
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2306 +/- ## ========================================== + Coverage 74.92% 74.95% +0.03% ========================================== Files 51 51 Lines 4227 4233 +6 ========================================== + Hits 3167 3173 +6 Misses 1060 1060
Continue to review full report at Codecov.
|
|
@rkrabek Thanks for your contribution. Could you add some to tests to ensure this is actually fixing something? I tried your fix with the following config: http://jsfiddle.net/moeumaj7/3/ And in this case it's actually break the display. |
|
@panthony Sorry for the delayed response, I've been super busy at work. I've updated the PR to include tests for bar width when tick fit is false. The config that you provided: http://jsfiddle.net/moeumaj7/3/ fails with my patch for the same reason it fails when you switch tick/fit to true as shown here: http://jsfiddle.net/ox76hL53/ This patch aims to fix this scenario (with or without the null data points): http://jsfiddle.net/dtttsa9d/ |