Fix destroy function to prevent null error during Pie chart animation#2188

Open

vtange wants to merge 1 commit intoc3js:masterfrom

Open

Fix destroy function to prevent null error during Pie chart animation#2188
vtange wants to merge 1 commit intoc3js:masterfrom
vtange:master

Conversation

Copy link

vtange commented Oct 4, 2017

addresses #2187
Modified .destroy function to not simply set $$.config and $$.data to null, as during a pie animation, these will quickly be checked as d3 animates things frame by frame. I set config back to the default, and data to an object with an empty targets array.


 fix destroy function to prevent null error during pie animation

8ef424b

Copy link

codecov-io commented Oct 4, 2017

Codecov Report

Merging #2188 into master will decrease coverage by 0.1%.
The diff coverage is 10%.

@@ Coverage Diff @@ ## master #2188 +/- ## ========================================== - Coverage 73.88% 73.77% -0.11% ========================================== Files 51 51 Lines 4185 4191 +6 ========================================== Hits 3092 3092 - Misses 1093 1099 +6

Impacted Files	Coverage D
src/interaction.js	`35.22% <0%> (o)`
src/api.chart.js	`10% <0%> (-2.5%)`
src/arc.js	`69.54% <100%> (o)`

Continue to review full report at Codecov.

Legend - Click here to learn more
D = absolute (impact), o = not affected, ? = missing data
Powered by Codecov. Last update 0391272...8ef424b. Read the comment docs.

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix destroy function to prevent null error during Pie chart animation#2188