Dark Mode

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Add explanation of why master branch is protected and push force should not happen #6

Open
Open
Add explanation of why master branch is protected and push force should not happen #6

Description

We did discussed that before and we ended up the current approach, minor changes can appear to be safe, but they may not be or could be done in a better way, so to avoid such problem and be sure that we are not doing something crazy, we agreed to have at least a single approved to any PR, more approves may be necessary if the change is complex or if you desire to have more eyes to be sure that the current approach is correct or may broken something that you are not aware.
We have master branch protected for the majority of our repositories.
PR's are really simple to do, and should not hold your workflow, you can open as much PRs that you feel like, or a single PR with a bunch of fixes. If you are waiting to merge something to add to the documentation before talking with an user, you can ping someone directly and we could approve asap.

I generally avoid committing directly to master, ever. Even a pr as simple as this one could break I forgot we are at Python 3.4 and tried to use f-strings in there.
while there is some extra work to it, these ones are pretty easy to do and quick to review.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions