Light Mode

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Auth/PM-21720 - RegisterFinishResponseModel - remove deprecated CaptchaBypassToken#7098

Open
JaredSnider-Bitwarden wants to merge 1 commit intomainfrom
auth/pm-21720/remove-captcha-bypass-token-register-finish-model
Open

Auth/PM-21720 - RegisterFinishResponseModel - remove deprecated CaptchaBypassToken#7098
JaredSnider-Bitwarden wants to merge 1 commit intomainfrom
auth/pm-21720/remove-captcha-bypass-token-register-finish-model

Conversation

Copy link
Contributor

JaredSnider-Bitwarden commented Feb 26, 2026 *
edited
Loading

Tracking

https://bitwarden.atlassian.net/browse/PM-21720

Objective

Clean up deprecated code. Note: I considered deleting the RegisterFinishResponseModel since it has no properties + converting to IActionResult, but I chose to avoid changing the API for now and the typed return is more explicit. It's also harmless and easy to extend if need be in the future.

JaredSnider-Bitwarden requested a review from a team as a code owner February 26, 2026 23:57
JaredSnider-Bitwarden requested a review from enmande February 26, 2026 23:57
Copy link

sonarqubecloud bot commented Feb 27, 2026

Copy link
Contributor

github-actions bot commented Feb 27, 2026


Checkmarx One - Scan Summary & Details - 76ec282e-55c6-4c4b-b347-59b88ca43a18

Great job! No new security vulnerabilities introduced in this pull request

Copy link

codecov bot commented Feb 27, 2026

Codecov Report

All modified and coverable lines are covered by tests.
Project coverage is 56.69%. Comparing base (d17d43c) to head (d6061ac).
Report is 1 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@
## main #7098 +/- ##
==========================================
- Coverage 56.69% 56.69% -0.01%
==========================================
Files 2013 2013
Lines 88171 88167 -4
Branches 7856 7856
==========================================
- Hits 49987 49984 -3
+ Misses 36363 36362 -1
Partials 1821 1821

View full report in Codecov by Sentry.
Have feedback on the report? Share it here.

New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

enmande Awaiting requested review from enmande enmande is a code owner automatically assigned from bitwarden/team-auth-dev

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant