Dark Mode

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings
This repository was archived by the owner on Apr 29, 2025. It is now read-only.

Enabling sort_attribute#138

Open
luord wants to merge 9 commits intobiosustain:masterfrom
luord:default-sort
Open

Enabling sort_attribute#138
luord wants to merge 9 commits intobiosustain:masterfrom
luord:default-sort

Conversation

Copy link
Contributor

luord commented Jul 16, 2018

In a project I did recently, I needed to change the default sort, I saw that this attribute existed in the Meta class for ModelResource, but wasn't being used.

This PR is an attempt of enabling it for usage.

Copy link
Contributor Author

luord commented Jul 24, 2018

Hadn't noticed the conflicts, updated now with the conflicts fixed.

Copy link
Contributor Author

luord commented Dec 6, 2018

Merged the reversion from the other branch.

Don't know if this will ever be merged but, for what it's worth, I think the sort_attribute should be passed as an argument and not decided exclusively from the meta in each manager.

This way loosens coupling, IMO, and the sort could work for any manager and not just sqlalchemy, plus it's more consistent on what the sort is expected to be. Namely a tuple of the field, its name and reverse.

Copy link

coveralls commented Dec 8, 2018 *
edited
Loading

Coverage increased (+0.06%) to 89.172% when pulling 22a5d64 on luord:default-sort into 66f11dc on biosustain:master.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants