This repository was archived by the owner on Dec 15, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 277
Added result sorting by downloads and/or stars#1203
Open
glenntanner3 wants to merge 1 commit intoatom:masterfrom
Open
Added result sorting by downloads and/or stars#1203glenntanner3 wants to merge 1 commit intoatom:masterfrom
glenntanner3 wants to merge 1 commit intoatom:masterfrom
Conversation
- Was unable to add the checkboxes side-by-side, due to overlapping, thus I stacked them.
- Set most downloads as the prefered order.
- Selection change invokes search.
- Did not add a method for default selection as I do not know how to.
Description of the Change
In response to atom/atom.io#9, this will allow the user to sort searched package/template results by downloads and/or stars value greatest to least.
Alternate Designs
Dropdown for more order combinations.
Time was the primary factor in only providing checkboxes and greatest to least.
Benefits
New users will be able to determine what others are using, most popular tend to be the best maintained.
Possible Drawbacks
Newer better packages may get overlooked
Applicable Issues
Config for default sorting method wasn't implemented as I wasn't sure how to.
* Was unable to add the checkboxes side-by-side, due to overlapping, thus I stacked them.
* Set most downloads as the prefered order.
* Selection change invokes search.
* Did not add a method for default selection as I do not know how to.
* Set most downloads as the prefered order.
* Selection change invokes search.
* Did not add a method for default selection as I do not know how to.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.