-
Notifications
You must be signed in to change notification settings - Fork 3k
set default extPlugin path to relative path.#5632
Open
initialdmg wants to merge 145 commits intoapache:masterfrom
Open
set default extPlugin path to relative path.#5632initialdmg wants to merge 145 commits intoapache:masterfrom
initialdmg wants to merge 145 commits intoapache:masterfrom
Conversation
Contributor
Current default value of extPlugin path /ext-lib/ is not consistent with described in deployment document,which resulting custom plugin jars auto loading failed. On Windows, bootstrap binary package's startup context is bin directory, ext plugin relative path is not correct too.
Make sure that:
- You have read the contribution guidelines.
- You submit test cases (unit or integration tests) that back your changes.
- Your local test passed
./mvnw clean install -Dmaven.javadoc.skip=true.
yu199195
reviewed
Aug 28, 2024
shenyu-web/src/main/java/org/apache/shenyu/web/loader/ShenyuPluginPathBuilder.java
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.