-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[fix][fn] Fix graceful Pulsar Function shutdown so that consumers and producers are closed#25157
Merged
lhotari merged 1 commit intoapache:masterfrom Jan 16, 2026
Merged
[fix][fn] Fix graceful Pulsar Function shutdown so that consumers and producers are closed#25157lhotari merged 1 commit intoapache:masterfrom
lhotari merged 1 commit intoapache:masterfrom
Conversation
Member
Fixes #25154
Motivation
While investigating a flaky test, I noticed that a Pulsar Function instance didn't shutdown gracefully due to interrupted thread status. The change in #25140 brought this to surface since closing producers gracefully requires that the calling thread isn't interrupted.
Modifications
Clear the interrupted state of the current thread in the Function instance before proceeding to call the close method.
Documentation
-
doc -
doc-required -
doc-not-needed -
doc-complete
... producers are closed
lhotari
requested review from
BewareMyPower,
Technoboy-,
codelipenghui,
dao-jun,
merlimat and
nodece
January 16, 2026 12:50
nodece
approved these changes
Jan 16, 2026
liangyepianzhou
approved these changes
Jan 16, 2026
Contributor
liangyepianzhou
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov Report All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #25157 +/- ## ============================================= + Coverage 37.48% 72.53% +35.05% - Complexity 13220 34226 +21006 ============================================= Files 1899 1956 +57 Lines 150586 154750 +4164 Branches 17159 17645 +486 ============================================= + Hits 56440 112241 +55801 + Misses 86464 33539 -52925 - Partials 7682 8970 +1288
Flags with carried forward coverage won't be shown. Click here to find out more.
New features to boost your workflow:
|
manas-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jan 19, 2026
... producers are closed (apache#25157)
(cherry picked from commit 0bf560f)
(cherry picked from commit dfb172e)
(cherry picked from commit 0bf560f)
(cherry picked from commit dfb172e)
priyanshu-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jan 20, 2026
... producers are closed (apache#25157)
(cherry picked from commit 0bf560f)
(cherry picked from commit 4183569)
(cherry picked from commit 0bf560f)
(cherry picked from commit 4183569)
manas-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jan 20, 2026
... producers are closed (apache#25157)
(cherry picked from commit 0bf560f)
(cherry picked from commit dfb172e)
(cherry picked from commit 0bf560f)
(cherry picked from commit dfb172e)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jan 20, 2026
... producers are closed (apache#25157)
(cherry picked from commit 0bf560f)
(cherry picked from commit 4183569)
(cherry picked from commit 0bf560f)
(cherry picked from commit 4183569)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jan 28, 2026
... producers are closed (apache#25157)
(cherry picked from commit 0bf560f)
(cherry picked from commit dfb172e)
(cherry picked from commit 0bf560f)
(cherry picked from commit dfb172e)
Rutuja-IBM
pushed a commit
to datastax/pulsar
that referenced
this pull request
Feb 9, 2026
... producers are closed (apache#25157)
(cherry picked from commit 0bf560f)
(cherry picked from commit dfb172e)
(cherry picked from commit 0bf560f)
(cherry picked from commit dfb172e)
Rutuja-IBM
pushed a commit
to datastax/pulsar
that referenced
this pull request
Feb 9, 2026
... producers are closed (apache#25157)
(cherry picked from commit 0bf560f)
(cherry picked from commit dfb172e)
(cherry picked from commit 0bf560f)
(cherry picked from commit dfb172e)
Rutuja-IBM
pushed a commit
to datastax/pulsar
that referenced
this pull request
Feb 12, 2026
... producers are closed (apache#25157)
(cherry picked from commit 0bf560f)
(cherry picked from commit dfb172e)
(cherry picked from commit 0bf560f)
(cherry picked from commit dfb172e)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.