-
Notifications
You must be signed in to change notification settings - Fork 427
Added CCC and close notify capabilities#49
Open
b-wagner wants to merge 2 commits intoapache:2.1.Xfrom
Open
Conversation
Added clear command channel (CCC) and close notify support, based off of our forked revisions that we use with our ftpserver fork.
Ben Wagner
added 2 commits
April 1, 2025 10:44
b-wagner
commented
Apr 2, 2025
| IoBuffer buf = (IoBuffer) message; | ||
|
|
||
| try { | ||
| if (sslHandler.isOutboundDone() && !sslHandler.isCCCEnabled()) { |
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This entire 'if' block was originally commented out in our fork, citing issues with CCC and close notify. To not break backwards compatibility, I added the addition check for CCC enabled.
Contributor
|
Hi! I'll review the proposed change soon. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.