Dark Mode

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Fix flaky test in TestDirectoryReaderReopen, #1233#1234

Open
paulirwin wants to merge 1 commit intoapache:masterfrom
paulirwin:issue/1233
Open

Fix flaky test in TestDirectoryReaderReopen, #1233#1234
paulirwin wants to merge 1 commit intoapache:masterfrom
paulirwin:issue/1233

Conversation

Copy link
Contributor

paulirwin commented Jan 12, 2026

  • You've read the Contributor Guide and Code of Conduct.
  • You've included unit or integration tests for your change, where applicable.
  • You've included inline docs for your change, where applicable.
  • There's an open issue for the PR that you are making. If you'd like to propose a change, please open an issue to discuss the change or find an existing issue.

Fixes a rare flaky test in TestDirectoryReaderReopen.

Fixes #1233

Description

The flaky failure is a rare race condition that only occurs under heavy concurrent load and is unrelated to what is under test. An analysis of this issue (with the help of Claude Code) found that we can safely catch this unrelated exception that is due to extremely minute timing issues that are impractical to attempt to reproduce. Real-world usage patterns with real I/O would likely never encounter this issue.

paulirwin added the notes:bug-fix Contains a fix for a bug label Jan 12, 2026
paulirwin mentioned this pull request Jan 13, 2026
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

notes:bug-fix Contains a fix for a bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Flaky Test: TestDirectoryReaderReopen.TestThreadSafety

1 participant