Dark Mode

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Fix #5213: Correct retry ack handling in DownStreamMsgContext#5221

Open
nagarjunahp88-byte wants to merge 1 commit intoapache:masterfrom
nagarjunahp88-byte:fix-5213-retry-ack-clean
Open

Fix #5213: Correct retry ack handling in DownStreamMsgContext#5221
nagarjunahp88-byte wants to merge 1 commit intoapache:masterfrom
nagarjunahp88-byte:fix-5213-retry-ack-clean

Conversation

Copy link

nagarjunahp88-byte commented Dec 24, 2025

What does this PR do?

This PR fixes the retry acknowledgment handling logic in
DownStreamMsgContext to correctly handle timeout scenarios
and prevent incorrect retry behavior.

What was the problem?

The existing logic could incorrectly retry or acknowledge
messages even after the configured TTL was exceeded, leading
to unexpected message handling behavior.

How was it fixed?

  • Corrected the retry ack decision logic based on elapsed time
  • Ensured retries are discarded once TTL is exceeded
  • Added unit tests to validate retry ack timeout scenarios

Tests

  • Added unit tests for retry acknowledgment behavior

Fixes #5213

Copy link
Contributor

github-actions bot commented Feb 22, 2026

It has been 60 days since the last activity on this pull request. I am reaching out here to gently remind you that the Apache EventMesh community values every pull request, and please feel free to get in touch with the reviewers at any time. They are available to assist you in advancing the progress of your pull request and offering the latest feedback.

If you encounter any challenges during development, seeking support within the community is encouraged. We sincerely appreciate your contributions to Apache EventMesh.

github-actions bot added the Stale label Feb 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Projects

None yet

Milestone

No milestone

1 participant