Dark Mode

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[ISSUE #4990] Add unit test for HttpConvertsUtils.java#5110

Merged
harshithasudhakar merged 7 commits intoapache:masterfrom
KrispauI:dev
Oct 8, 2024
Merged

[ISSUE #4990] Add unit test for HttpConvertsUtils.java#5110
harshithasudhakar merged 7 commits intoapache:masterfrom
KrispauI:dev

Conversation

Copy link
Contributor

KrispauI commented Sep 28, 2024

Fixes #4990

Motivation

HttpConvertsUtils.java at eventmesh-common/src/test/java/org/apache/eventmesh/common/utils do not have its unit test, and the test coverage needs to be expanded.

Modifications

Added HttpConvertsUtilsTest.java located at eventmesh-runtime/src/test/java/org/apache/eventmesh/common/util

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? not applicable

github-actions bot reviewed Sep 28, 2024
Copy link
Contributor

github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to the Apache EventMesh community!!
This is your first PR in our project. We're very excited to have you onboard contributing. Your contributions are greatly appreciated!

Please make sure that the changes are covered by tests.
We will be here shortly.
Let us know if you need any help!

Want to get closer to the community?

WeChat Assistant WeChat Public Account Slack
Join Slack Chat

Mailing Lists:

Name Description Subscribe Unsubscribe Archive
Users User support and questions mailing list Subscribe Unsubscribe Mail Archives
Development Development related discussions Subscribe Unsubscribe Mail Archives
Commits All commits to repositories Subscribe Unsubscribe Mail Archives
Issues Issues or PRs comments and reviews Subscribe Unsubscribe Mail Archives

Copy link
Member

harshithasudhakar commented Oct 1, 2024

Please fix the CI errors

dependabot bot and others added 5 commits October 8, 2024 17:00
Bumps com.gradle.develocity from 3.17.5 to 3.18.1.

---
updated-dependencies:
- dependency-name: com.gradle.develocity
dependency-type: direct:production
update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot]
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps software.amazon.awssdk:s3 from 2.27.17 to 2.28.12.

---
updated-dependencies:
- dependency-name: software.amazon.awssdk:s3
dependency-type: direct:production
update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot]
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [com.rabbitmq:amqp-client](https://github.com/rabbitmq/rabbitmq-java-client) from 5.21.0 to 5.22.0.
- [Release notes](https://github.com/rabbitmq/rabbitmq-java-client/releases)
- [Commits](rabbitmq/rabbitmq-java-client@v5.21.0...v5.22.0)

---
updated-dependencies:
- dependency-name: com.rabbitmq:amqp-client
dependency-type: direct:production
update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot]
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
xwm1992 approved these changes Oct 8, 2024
harshithasudhakar approved these changes Oct 8, 2024
harshithasudhakar merged commit 7abe42a into apache:master Oct 8, 2024
xwm1992 added this to the 1.11.0 milestone Dec 17, 2024
xuhongjia pushed a commit to Deckers-Ohana/eventmesh that referenced this pull request Mar 13, 2025
...5110)

* add unit test for HttpConvertsUtils.java

* fix package error

* Bump com.gradle.develocity from 3.17.5 to 3.18.1 (apache#5121)

Bumps com.gradle.develocity from 3.17.5 to 3.18.1.

---
updated-dependencies:
- dependency-name: com.gradle.develocity
dependency-type: direct:production
update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot]
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump software.amazon.awssdk:s3 from 2.27.17 to 2.28.12 (apache#5120)

Bumps software.amazon.awssdk:s3 from 2.27.17 to 2.28.12.

---
updated-dependencies:
- dependency-name: software.amazon.awssdk:s3
dependency-type: direct:production
update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot]
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* [ISSUE apache#4540] Add unit test for ThreadUtils (apache#5111)

* Bump com.rabbitmq:amqp-client from 5.21.0 to 5.22.0 (apache#5119)

Bumps [com.rabbitmq:amqp-client](https://github.com/rabbitmq/rabbitmq-java-client) from 5.21.0 to 5.22.0.
- [Release notes](https://github.com/rabbitmq/rabbitmq-java-client/releases)
- [Commits](rabbitmq/rabbitmq-java-client@v5.21.0...v5.22.0)

---
updated-dependencies:
- dependency-name: com.rabbitmq:amqp-client
dependency-type: direct:production
update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot]
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* fix CI errors

---------

Signed-off-by: dependabot[bot]
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Melis Olmez <77929541+melisolmez@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

github-actions[bot] github-actions[bot] left review comments

xwm1992 xwm1992 approved these changes

harshithasudhakar harshithasudhakar approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

1.11.0

Development

Successfully merging this pull request may close these issues.

[Unit Test] Unit test for HttpConvertsUtils.java

4 participants