-
Notifications
You must be signed in to change notification settings - Fork 646
[ISSUE #4991] add unit test for LogUtil#5100
Conversation
Fixes #4991
Motivation
Increase test coverage
Modifications
Added new tests for LogUtil.java located https://github.com/apache/eventmesh/blob/master/eventmesh-common/src/main/java/org/apache/eventmesh/common/utils/LogUtilTest.java
Documentation
Does this pull request introduce a new feature? (no)
If yes, how is the feature documented? (not applicable)
If a feature is not applicable for documentation, explain why?
If a feature is not documented yet in this PR, please create a followup issue for adding the documentation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome to the Apache EventMesh community!!
This is your first PR in our project. We're very excited to have you onboard contributing. Your contributions are greatly appreciated!
Please make sure that the changes are covered by tests.
We will be here shortly.
Let us know if you need any help!
Want to get closer to the community?
| WeChat Assistant | WeChat Public Account | Slack |
|---|---|---|
| Join Slack Chat |
Mailing Lists:
| Name | Description | Subscribe | Unsubscribe | Archive |
|---|---|---|---|---|
| Users | User support and questions mailing list | Subscribe | Unsubscribe | Mail Archives |
| Development | Development related discussions | Subscribe | Unsubscribe | Mail Archives |
| Commits | All commits to repositories | Subscribe | Unsubscribe | Mail Archives |
| Issues | Issues or PRs comments and reviews | Subscribe | Unsubscribe | Mail Archives |
|
Hi, please resolve the failing CI errors. To resolve the issue, you can view the test report generated during the build. |
|
hello @harshithasudhakar, I tried solve this problem but I cannot understand. There were failing tests. See the report at: file:///Users/runner/work/eventmesh/eventmesh/eventmesh-comm on/build/reports/tests/test/index.html when I saw this location but there is not fail test in index.html. Could you help with this problem? |
|
I re-ran the build, it has passed :) |
|
@harshithasudhakar Hello, I want to close this PR. I need someone else to accept it. Can you help me? |
|
good job |