-
Notifications
You must be signed in to change notification settings - Fork 138
Fix concurrent map flakiness#472
Open
shunfan-shao wants to merge 5 commits intoapache:masterfrom
shunfan-shao:fix-concurrent-map-flakiness
Open
Fix concurrent map flakiness#472shunfan-shao wants to merge 5 commits intoapache:masterfrom shunfan-shao:fix-concurrent-map-flakiness
shunfan-shao wants to merge 5 commits intoapache:masterfrom
shunfan-shao:fix-concurrent-map-flakiness
Conversation
Description
Test org.apache.cayenne.util.WeakValueMapTest.testConcurrentModification will fail under NonDex which detects flakiness under non-deterministic environment.
To reproduce:
mvn edu.illinois:nondex-maven-plugin:1.1.2:nondex \
-pl cayenne-server \
-Dtest=org.apache.cayenne.util.WeakValueMapTest#testConcurrentModification
Issue
The test code follows the logic below:
Map<String, Integer> map = new WeakValueMap<>(3);
for(Map.Entry<String, Integer> entry : map.entrySet()) {
if("key_2".equals(entry.getKey()))
map.remove("key_2");
}
for(Map.Entry<String, Integer> entry : map.entrySet()) {
if("key_2".equals(entry.getKey()))
map.remove("key_2");
}
While WeakValueMap uses HashMap internally, it is not guaranteed for map.entrySet to iterate over the entries under some orders.
The code is expected to thrown ConcurrentModificationException during execution. Under some edge cases, eg: key_2 is traversed and removed last, the test will fail to throw and cause an issue.
Shao
and others
added 5 commits
September 5, 2021 09:56
fix: replace non deterministic order data structure
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.