-
Notifications
You must be signed in to change notification settings - Fork 16.6k
Fix infinite password retry loop in airflowctl EncryptedKeyring initialization#61329
Merged
dheerajturaga merged 1 commit intoapache:mainfrom Feb 1, 2026
Merged
Fix infinite password retry loop in airflowctl EncryptedKeyring initialization#61329dheerajturaga merged 1 commit intoapache:mainfrom
dheerajturaga merged 1 commit intoapache:mainfrom
Conversation
Member
The upstream keyrings.alt EncryptedKeyring prompts for a new keyring
password in an unbounded while-True loop when the keyring file does not
yet exist. The active backend is typically a ChainerBackend that wraps
EncryptedKeyring as a child, so the patch walks into .backends to find
and replace _get_new_password before keyring.set_password() can trigger
initialization. Raises AirflowCtlKeyringException after 3 attempts.
Was generative AI tooling used to co-author this PR?
- Yes (please specify the tool below)
ClaudeCode
...alization
The upstream keyrings.alt EncryptedKeyring prompts for a new keyring
password in an unbounded while-True loop when the keyring file does not
yet exist. The active backend is typically a ChainerBackend that wraps
EncryptedKeyring as a child, so the patch walks into .backends to find
and replace _get_new_password before keyring.set_password() can trigger
initialization. Raises AirflowCtlKeyringException after 3 attempts.
The upstream keyrings.alt EncryptedKeyring prompts for a new keyring
password in an unbounded while-True loop when the keyring file does not
yet exist. The active backend is typically a ChainerBackend that wraps
EncryptedKeyring as a child, so the patch walks into .backends to find
and replace _get_new_password before keyring.set_password() can trigger
initialization. Raises AirflowCtlKeyringException after 3 attempts.
bugraoz93
approved these changes
Feb 1, 2026
Contributor
bugraoz93
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, good one!
shashbha14
pushed a commit
to shashbha14/airflow
that referenced
this pull request
Feb 2, 2026
jason810496
pushed a commit
to abhijeets25012-tech/airflow
that referenced
this pull request
Feb 3, 2026
jhgoebbert
pushed a commit
to jhgoebbert/airflow_Owen-CH-Leung
that referenced
this pull request
Feb 8, 2026
Ratasa143
pushed a commit
to Ratasa143/airflow
that referenced
this pull request
Feb 15, 2026
25 tasks
choo121600
pushed a commit
to choo121600/airflow
that referenced
this pull request
Feb 22, 2026
Subham-KRLX
pushed a commit
to Subham-KRLX/airflow
that referenced
this pull request
Mar 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.