-
Notifications
You must be signed in to change notification settings - Fork 16.6k
Remove workers.celery breaking change#61049
Conversation
related: #28880
The goal of this PR is to remove the breaking change behaviour introduced by the values under workers.celery, which have a default that differs from nil.
Some test cases were deleted, as they were checking logic for breaking change behaviour.
Was generative AI tooling used to co-author this PR?
- Yes (please specify the tool below)
- Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
- For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
- When adding dependency, check compliance with the ASF 3rd Party License Policy.
- For significant user-facing changes create newsfragment:
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.
jscheffl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume your PR is a bit leaner. Have no time to thorowly inspect, need to get to bed now finally. Except 3 comments nothing bad obviously seen.
potiuk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
bugraoz93
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Trying to review and revert the PR before release, as discussed in Slack. Thanks a lot for the PR!