-
Notifications
You must be signed in to change notification settings - Fork 16.7k
Correct the access for the externalLogUrl#60412
Merged
shubhamraj-git merged 2 commits intoapache:mainfrom Jan 13, 2026
Merged
Conversation
Contributor
External log URL retrieval should require the Task Logs permission similar to Log content. Users without Task Logs permission should not be able to access any log-related endpoints.
- Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
- For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
- When adding dependency, check compliance with the ASF 3rd Party License Policy.
- For significant user-facing changes create newsfragment:
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.
shubhamraj-git
requested review from
bugraoz93,
choo121600,
ephraimbuddy,
jason810496,
pierrejeambrun and
rawwar
as code owners
January 12, 2026 15:24
jason810496
reviewed
Jan 12, 2026
Member
jason810496
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix!
It would be nice to update the corresponding tests, thanks!
pierrejeambrun
approved these changes
Jan 13, 2026
Contributor
Author
|
Thanks @jason810496 and @pierrejeambrun for the review. |
Member
feel free :) |
potiuk
approved these changes
Jan 13, 2026
potiuk
added
the
backport-to-v3-1-test
Mark PR with this label to backport to v3-1-test branch
label
Jan 13, 2026
github-actions bot
pushed a commit
that referenced
this pull request
Jan 13, 2026
(cherry picked from commit 934409f)
Co-authored-by: Shubham Raj <48172486+shubhamraj-git@users.noreply.github.com>
Co-authored-by: Shubham Raj <48172486+shubhamraj-git@users.noreply.github.com>
shubhamraj-git
added a commit
that referenced
this pull request
Jan 14, 2026
ephraimbuddy
pushed a commit
that referenced
this pull request
Jan 14, 2026
ephraimbuddy
pushed a commit
that referenced
this pull request
Jan 16, 2026
jason810496
pushed a commit
to jason810496/airflow
that referenced
this pull request
Jan 22, 2026
jhgoebbert
pushed a commit
to jhgoebbert/airflow_Owen-CH-Leung
that referenced
this pull request
Feb 8, 2026
choo121600
pushed a commit
to choo121600/airflow
that referenced
this pull request
Feb 22, 2026
Subham-KRLX
pushed a commit
to Subham-KRLX/airflow
that referenced
this pull request
Mar 4, 2026
Ankurdeewan
pushed a commit
to Ankurdeewan/airflow
that referenced
this pull request
Mar 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.